alpenlabs / strata

Rust implementation of the Strata protocol
https://docs.stratabtc.org
Apache License 2.0
23 stars 1 forks source link

consensus-logic: Use ClientUpdateNotif instead of FCMessage::NewState #422

Closed bewakes closed 2 weeks ago

bewakes commented 3 weeks ago

Description

This PR removes the cycle between FCM worker and CSM worker by having CSM send NewState message to FCM via ClientUpdateNotif instead of ForkChoiceMessage::NewState.

Type of Change

Checklist

Related Issues

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 57.09%. Comparing base (a14d926) to head (a8ec132). Report is 6 commits behind head on releases/0.1.0.

Files with missing lines Patch % Lines
crates/consensus-logic/src/fork_choice_manager.rs 0.00% 38 Missing :warning:
crates/consensus-logic/src/worker.rs 0.00% 5 Missing :warning:
crates/consensus-logic/src/sync_manager.rs 0.00% 2 Missing :warning:
@@                Coverage Diff                 @@
##           releases/0.1.0     #422      +/-   ##
==================================================
- Coverage           57.16%   57.09%   -0.08%     
==================================================
  Files                 256      257       +1     
  Lines               27048    27122      +74     
==================================================
+ Hits                15462    15484      +22     
- Misses              11586    11638      +52     
Files with missing lines Coverage Δ
crates/consensus-logic/src/message.rs 0.00% <ø> (ø)
crates/consensus-logic/src/sync_manager.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/worker.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/fork_choice_manager.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

bewakes commented 2 weeks ago

closing this in favor of the next PR: https://github.com/alpenlabs/strata/pull/434 which is branched off of release branch.