func-tests: Bridge Deposit Reclaim Path

storopoli commented 2 weeks ago

Description

Tests the unhappy path of a deposit request transaction (DRT), i.e. when the bridge has failed to process DRT into a deposit transaction (DT) after the recover delay (here ~1 week, or 1008 blocks).

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Refactor
[x] New or updated tests

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

Related Issues

STR-418

storopoli commented 1 week ago

Ok the rust part is ready to review. It works! Gonna work on the Python fn test now. @Zk2u since this builds upon your work at strata-cli you are well equipped to check the rust code in this PR.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 87.63251% with 35 lines in your changes missing coverage. Please review.

Project coverage is 57.28%. Comparing base (21fa908) to head (c36e05c). Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/util/python-utils/src/drt.rs	85.10%	28 Missing :warning:
crates/util/python-utils/src/lib.rs	0.00%	3 Missing :warning:
crates/util/python-utils/src/taproot.rs	94.33%	3 Missing :warning:
crates/util/python-utils/src/error.rs	0.00%	1 Missing :warning:

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   57.03%   57.28%   +0.25%     
==========================================
  Files         252      252              
  Lines       27950    28207     +257     
==========================================
+ Hits        15940    16158     +218     
- Misses      12010    12049      +39

Files with missing lines	Coverage Δ
crates/util/python-utils/src/constants.rs	`100.00% <100.00%> (ø)`
crates/util/python-utils/src/parse.rs	`100.00% <100.00%> (ø)`
crates/util/python-utils/src/error.rs	`0.00% <0.00%> (ø)`
crates/util/python-utils/src/lib.rs	`0.00% <0.00%> (ø)`
crates/util/python-utils/src/taproot.rs	`60.74% <94.33%> (+9.19%)`	:arrow_up:
crates/util/python-utils/src/drt.rs	`85.30% <85.10%> (+0.37%)`	:arrow_up:

... and 6 files with indirect coverage changes

Zk2u commented 1 week ago

@storopoli do you want a review on this now or wait until it's feature complete?

alpenlabs / strata