backport: print strata explorer links if configured (#453)

storopoli commented 1 week ago

Description

Backport strata-cli feature to show blockscout links to withdraw transactions.

Blocked by https://github.com/alpenlabs/private-docs/pull/51

[ ] Tag 0.1.1 since https://github.com/alpenlabs/private-docs/pull/51/commits/7ba2d2143fd41dba1119d6c628bdaa7dfbe58b0a

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Refactor
[ ] New or updated tests

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

Related Issues

STR-554

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 56.92%. Comparing base (a14d926) to head (5c1b260). Report is 32 commits behind head on releases/0.1.0.

Files with missing lines	Patch %	Lines
bin/strata-cli/src/strata.rs	0.00%	12 Missing :warning:
bin/strata-cli/src/signet.rs	0.00%	11 Missing :warning:
bin/strata-cli/src/cmd/drain.rs	0.00%	4 Missing :warning:
bin/strata-cli/src/settings.rs	0.00%	4 Missing :warning:
bin/strata-cli/src/cmd/faucet.rs	0.00%	2 Missing :warning:
bin/strata-cli/src/cmd/send.rs	0.00%	2 Missing :warning:
bin/strata-cli/src/cmd/withdraw.rs	0.00%	2 Missing :warning:
bin/strata-cli/src/cmd/deposit.rs	0.00%	1 Missing :warning:

@@                Coverage Diff                 @@
##           releases/0.1.0     #454      +/-   ##
==================================================
- Coverage           57.16%   56.92%   -0.25%     
==================================================
  Files                 256      263       +7     
  Lines               27048    28017     +969     
==================================================
+ Hits                15462    15948     +486     
- Misses              11586    12069     +483

Files with missing lines	Coverage Δ
bin/strata-cli/src/cmd/deposit.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/cmd/faucet.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/cmd/send.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/cmd/withdraw.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/cmd/drain.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/settings.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/signet.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/strata.rs	`0.00% <0.00%> (ø)`

... and 25 files with indirect coverage changes

Zk2u commented 1 week ago

Not blocked, this is non breaking and can be merged before docs merge

storopoli commented 1 week ago

Alright let's wait for @sapinb to have a look. This should be a squash merge as always with releases/ branches

storopoli commented 1 week ago

Ok I'm merging this

alpenlabs / strata