alpernebbi / git-annex-metadata-gui

Graphical interface for git-annex metadata commands
GNU General Public License v3.0
59 stars 4 forks source link

Crashes after clicking on annex'ed file without content #6

Closed yarikoptic closed 7 years ago

yarikoptic commented 7 years ago
hopa:~/datalad/labs/haxby/raiders
$> git-annex-metadata-gui .
Traceback (most recent call last):
  File "/home/yoh/proj/datalad/3rd/git-annex-metadata-gui/git_annex_metadata_gui/gui.py", line 222, in selection_updated
    self.docks.preview.set_item(item)
  File "/home/yoh/proj/datalad/3rd/git-annex-metadata-gui/git_annex_metadata_gui/docks.py", line 65, in set_item
    if mime.startswith('text/'):
AttributeError: 'NoneType' object has no attribute 'startswith'
[1]    7003 abort      git-annex-metadata-gui .

I guess getting some at least smoke tests (not yet sure how easy/difficult but should be possible with all the GUI nature) could benefit I guess the "stability" ;)

alpernebbi commented 7 years ago

Well, I had been sneaky again and fixed it yesterday (54eb659), so closing this.