search

alpha-asp / Alpha

A lazy-grounding Answer-Set Programming system
BSD 2-Clause "Simplified" License
58 stars 10 forks source link

Improve Travis CI build Performance #293

Closed chenzhang22 closed 3 years ago

chenzhang22 commented 3 years ago

According to Build times out because no output was received, we should carefully use travis_wait, as it may make the build unstable and extend the build time.

===================== If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

AntoniusW commented 3 years ago

Hello YunLemon,

can you please provide more information on why you see an issue here?

chenzhang22 commented 3 years ago

why u use travis_wait? I think travis_wait means the result of the command may be uncertain. If this command is quick or always has output, travis_wait is useless. If sometimes this command isblocked and without producing any output, then the result is uncertain.

AntoniusW commented 3 years ago

Dear YunLemon,

you suggested to remove the travis_wait command from our builds, so you should know what it is doing and you should make sure that removing the command is okay. Do you know what travis_wait is doing in this project? Are you sure our Travis CI builds are still running as intended?

From your above questions I see that you have not really understood what travis_wait does. And since no Travis CI tests completed for this branch, I am pretty sure that you have no idea whether our tests still work as intended. I also see that you opened hundreds of similar pull requests on other projects. I doubt that you understood why those travis_wait commands are in any of those other projects and yet you try to convince everybody to remove it. This is very unprofessional behaviour and I sincerely ask you to stop it.

chenzhang22 commented 3 years ago

How professional u are. You write a long comment, but I see nothing useful. This project seems no longer use Travis CI, and I can't see the build logs, so I'm not sure what has happened to this command. But from the build log of appveyor, I think travis_wait is not needed.