Closed lorenzleutgeb closed 2 years ago
Merging #314 (70c33f2) into master (094dd3b) will decrease coverage by
4.44%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #314 +/- ##
============================================
- Coverage 78.50% 74.06% -4.45%
- Complexity 2517 4609 +2092
============================================
Files 189 371 +182
Lines 8199 16205 +8006
Branches 1417 2833 +1416
============================================
+ Hits 6437 12002 +5565
- Misses 1319 3405 +2086
- Partials 443 798 +355
Impacted Files | Coverage Δ | |
---|---|---|
...ommons/comparisons/AbstractComparisonOperator.java | 0.00% <0.00%> (ø) |
|
.../ac/tuwien/kr/alpha/core/solver/ChoiceManager.java | 81.25% <0.00%> (ø) |
|
...java/at/ac/tuwien/kr/alpha/core/solver/Choice.java | 85.71% <0.00%> (ø) |
|
...c/tuwien/kr/alpha/commons/atoms/BasicAtomImpl.java | 32.65% <0.00%> (ø) |
|
...re/programs/transformation/ChoiceHeadToNormal.java | 85.00% <0.00%> (ø) |
|
...r/heuristics/activity/SumBodyActivityProvider.java | 0.00% <0.00%> (ø) |
|
...uwien/kr/alpha/commons/substitutions/Instance.java | 0.00% <0.00%> (ø) |
|
.../kr/alpha/core/grounder/FactIntervalEvaluator.java | 85.71% <0.00%> (ø) |
|
...ien/kr/alpha/core/parser/InlineDirectivesImpl.java | 83.33% <0.00%> (ø) |
|
...c/tuwien/kr/alpha/core/grounder/WorkingMemory.java | 86.11% <0.00%> (ø) |
|
... and 172 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 094dd3b...70c33f2. Read the comment docs.
Removed the entry for "Siemens AG" from "contributors". It's still there as the "affiliation" of @rtaupe, like it would appear on a paper. Hope that's okay.
To my understanding, Siemens AG is an author (in the copyright sense) because they paid someone (@rtaupe specifically) to work on Alpha during their working hours. Siemens AG agreed to the open source BSD license of that work, but they are still an author as far as I understand. I am not a lawyer, but I think we should have Siemens AG in the list of authors.
For more context, refer to:
The file should not see many changes (just like
AUTHORS
andCONTRIBUTORS
). The spec is quite broad and flexible, so we could encode much more, but I'd prefer to start with something simple.Opinions?