alpha-asp / Alpha

A lazy-grounding Answer-Set Programming system

BSD 2-Clause "Simplified" License

58 stars 10 forks source link

Fine-tune codebeat checks #334

Closed madmike200590 closed 2 years ago

madmike200590 commented 2 years ago

Adapt codebeat configuration in order to produce less warnings with "info" level and make codebeat stats more useful:

Assignment Branch Condition (ABC): 20-40 INFO, 40-60 WARN, 60-80 ERROR, >80 CRITICAL (default: 10, 20, 40, 60)
Lines of Code per file: 300-400 INFO, 400-500 WARN, 500-800 ERROR, >800 CRITICAL (default: 180, 240, 320, 420])
Methods per file: 25-35 INFO, 35-45 WARN, 45-60 ERROR, >60 CRITICAL (default: 15, 20, 30, 50)
Total complexity: 200-300 INFO, 300-400 WARN, 400-500 ERROR, >500 CRITICAL (default: 75, 150, 250, 350)

codecov[bot] commented 2 years ago

Codecov Report

Merging #334 (dbd8229) into master (d42818a) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #334   +/-   ##
=========================================
  Coverage     70.23%   70.23%           
  Complexity     2123     2123           
=========================================
  Files           182      182           
  Lines          8023     8023           
  Branches       1423     1423           
=========================================
  Hits           5635     5635           
  Misses         2028     2028           
  Partials        360      360

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d42818a...dbd8229. Read the comment docs.

lorenzleutgeb commented 2 years ago

Can we get away with just compressing INFO and WARN, leaving ERROR and CRITICAL at their defaults?

madmike200590 commented 2 years ago

Can we get away with just compressing INFO and WARN, leaving ERROR and CRITICAL at their defaults?

I think we could, but I don't see that much benefit - to come up with these values, I went through our current codebeat warnings and tried to find values that would result in most of the current INFOs going away, some WARNs being turned to INFO, and most of what's currently red staying like that. Files like NaiveGrounder.java, DefaultSolver.java etc. which are candidates for refactoring will stay red even with the more lenient values I suggested. On most other files, these values should result in either no warnings or a low number of INFOs - everything that still gives us a WARN is something that really needs looking at (at least that's the idea).