search

alpha-asp / Alpha

A lazy-grounding Answer-Set Programming system
BSD 2-Clause "Simplified" License
58 stars 10 forks source link

Revise RuleAtomData#compareTo #354

Closed madmike200590 closed 1 year ago

madmike200590 commented 1 year ago

Eliminates the implicit assumption for two compared RuleAtomDatas to have the same variables set and instead works off the occurring variables of the rule.

codecov[bot] commented 1 year ago

Codecov Report

Base: 70.61% // Head: 70.59% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (81e0b24) compared to base (5c93f91). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## ruleatom_nostring #354 +/- ## ======================================================= - Coverage 70.61% 70.59% -0.02% Complexity 2147 2147 ======================================================= Files 181 181 Lines 8045 8047 +2 Branches 1431 1433 +2 ======================================================= Hits 5681 5681 - Misses 1990 1992 +2 Partials 374 374 ``` | [Impacted Files](https://codecov.io/gh/alpha-asp/Alpha/pull/354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp) | Coverage Δ | | |---|---|---| | [...alpha/commons/substitutions/BasicSubstitution.java](https://codecov.io/gh/alpha-asp/Alpha/pull/354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtY29tbW9ucy9zcmMvbWFpbi9qYXZhL2F0L2FjL3R1d2llbi9rci9hbHBoYS9jb21tb25zL3N1YnN0aXR1dGlvbnMvQmFzaWNTdWJzdGl0dXRpb24uamF2YQ==) | `12.50% <0.00%> (ø)` | | | [...ava/at/ac/tuwien/kr/alpha/core/atoms/RuleAtom.java](https://codecov.io/gh/alpha-asp/Alpha/pull/354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtY29yZS9zcmMvbWFpbi9qYXZhL2F0L2FjL3R1d2llbi9rci9hbHBoYS9jb3JlL2F0b21zL1J1bGVBdG9tLmphdmE=) | `45.28% <0.00%> (-1.78%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

madmike200590 commented 1 year ago

Proposed change made obsolete by better solution.