search

alpha-asp / Alpha

A lazy-grounding Answer-Set Programming system
BSD 2-Clause "Simplified" License
58 stars 10 forks source link

Add Jacoco aggregation for coverage. #356

Closed AntoniusW closed 1 year ago

AntoniusW commented 1 year ago

Refactoring Alpha into modules resulted in coverage to be computed only individually for each module. This results in many lines of code being considered not hit by any test, while they indeed are tested in (functional-/integration-)tests of another module. This PR tries to rectify coverage computation by using Jacoco's aggregate plugin on the top-level of the build.

codecov[bot] commented 1 year ago

Codecov Report

Base: 66.83% // Head: 79.04% // Increases project coverage by +12.21% :tada:

Coverage data is based on head (2f34193) compared to base (3028684). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #356 +/- ## ============================================= + Coverage 66.83% 79.04% +12.21% + Complexity 2108 778 -1330 ============================================= Files 184 201 +17 Lines 8379 8671 +292 Branches 1464 1471 +7 ============================================= + Hits 5600 6854 +1254 + Misses 2411 1365 -1046 - Partials 368 452 +84 ``` | [Impacted Files](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp) | Coverage Δ | | |---|---|---| | [...va/at/ac/tuwien/kr/alpha/api/config/Heuristic.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb25maWcvSGV1cmlzdGljLmphdmE=) | `95.23% <0.00%> (ø)` | | | [.../at/ac/tuwien/kr/alpha/api/programs/Predicate.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9wcm9ncmFtcy9QcmVkaWNhdGUuamF2YQ==) | `100.00% <0.00%> (ø)` | | | [...at/ac/tuwien/kr/alpha/api/programs/atoms/Atom.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9wcm9ncmFtcy9hdG9tcy9BdG9tLmphdmE=) | `6.66% <0.00%> (ø)` | | | [...tuwien/kr/alpha/api/programs/rules/NormalRule.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9wcm9ncmFtcy9ydWxlcy9Ob3JtYWxSdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...ha/api/config/GrounderHeuristicsConfiguration.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb25maWcvR3JvdW5kZXJIZXVyaXN0aWNzQ29uZmlndXJhdGlvbi5qYXZh) | `92.00% <0.00%> (ø)` | | | [.../kr/alpha/api/config/AggregateRewritingConfig.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb25maWcvQWdncmVnYXRlUmV3cml0aW5nQ29uZmlnLmphdmE=) | `100.00% <0.00%> (ø)` | | | [.../fixedinterpretations/PredicateInterpretation.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb21tb24vZml4ZWRpbnRlcnByZXRhdGlvbnMvUHJlZGljYXRlSW50ZXJwcmV0YXRpb24uamF2YQ==) | `100.00% <0.00%> (ø)` | | | [...ac/tuwien/kr/alpha/api/programs/ProgramParser.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9wcm9ncmFtcy9Qcm9ncmFtUGFyc2VyLmphdmE=) | `40.00% <0.00%> (ø)` | | | [...at/ac/tuwien/kr/alpha/api/config/SystemConfig.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb25maWcvU3lzdGVtQ29uZmlnLmphdmE=) | `81.52% <0.00%> (ø)` | | | [.../at/ac/tuwien/kr/alpha/api/config/AlphaConfig.java](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp#diff-YWxwaGEtYXBpL3NyYy9tYWluL2phdmEvYXQvYWMvdHV3aWVuL2tyL2FscGhhL2FwaS9jb25maWcvQWxwaGFDb25maWcuamF2YQ==) | `100.00% <0.00%> (ø)` | | | ... and [65 more](https://codecov.io/gh/alpha-asp/Alpha/pull/356?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alpha-asp)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

AntoniusW commented 1 year ago

@lorenzleutgeb Since you are the one with the most Gradle experience in our team, could you have a look at this PR and check it? Thanks!