search

alpha-rudy / taiwan-topo

Taiwan Hiking Maps
58 stars 7 forks source link

Missing svg files in zip file, which is still been used in theme #31

Closed chihchun closed 6 years ago

chihchun commented 6 years ago 
% date -r MOI_OSM_Taiwan_TOPO_Rudy_style.zip -R
Thu, 16 Aug 2018 04:56:47 +0800
% sha256sum MOI_OSM_Taiwan_TOPO_Rudy_style.zip
a9784ccf4e31624e1da5c784737b031175d5ff9eacd25ee6dab601c1bd042e02 MOI_OSM_Taiwan_TOPO_Rudy_style.zip

Errors

SEVERE: invalid resource: moiosm_res/s_pt_bus_station.svg
SEVERE: invalid resource: moiosm_res/s_pt_bus.svg
SEVERE: invalid resource: moiosm_res/s_pt_rail_lz.svg
SEVERE: invalid resource: moiosm_res/s_pt_rail.svg
SEVERE: invalid resource: moiosm_res/s_pt_subway.svg

usage in theme

% grep s_pt_bus_station.svg styles/*/*xml
styles/locus_lite/MOI_OSM_Lite.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosmlite_res/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
styles/locus_style/MOI_OSM.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosm_res/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
styles/mapsforge_hs/MOI_OSM.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosmhs_res/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
styles/mapsforge_lite/MOI_OSM_Lite.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosmlite_res/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
styles/mapsforge_style/MOI_OSM.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosm_res/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
styles/twmap_style/MOI_OSM_twmap.xml: <symbol id="s_pt_bus_station" priority="112" src="file:moiosm_twmap/s_pt_bus_station.svg" symbol-scaling="size" symbol-height="12" symbol-width="12"/>
typebrook commented 6 years ago

Caused by some rules use deleted/renamed svg file. s_pt_bus_station.svg -> bus_station_a.svg s_pt_rail.svg -> s_pt_rail_taiwan.svg s_pt_bus.svg -> s_pt_bus_stop.svg/s_pt_bus_stop_shelter.svg s_pt_subway.svg -> s_pt_subway_taipei.svg

8381cb6aecdad25167530363a92aed630a0a830c apply newer svg files for these rules, should fix the problem. @alpha-rudy please check this modify goes well

typebrook commented 6 years ago

s_pt_rail_lz.svg -> s_pt_rail_taiwan.svg forgot to deal with s_pt_rail_lz.svg 5cf2306de903d891472525dc00ba529f1a9487d5

alpha-rudy commented 6 years ago

Hi @chihchun ,

The only visible layer is "elmt-hiking".

"elmt-city", "elmt-cycling", and "elmt-mtb" are all not visible. Are all these errors come from "elmt-hiking"?

Sincerely, Rudy 8/20

chihchun commented 6 years ago

On the server side mapsforge render, it will valid all style and image files are exist.

typebrook commented 6 years ago

Since missing files are fixed with newer svg file name, this issue should be closed. https://github.com/alpha-rudy/taiwan-topo/commit/8381cb6aecdad25167530363a92aed630a0a830c#r30208126