search

alpha-unito / streamflow

StreamFlow Workflow Manager
https://streamflow.di.unito.it
GNU Lesser General Public License v3.0
52 stars 13 forks source link

Fix `follow_symlink` function return value #542

Closed LanderOtto closed 1 month ago

LanderOtto commented 2 months ago

This commit fixes the follow_symlink function. Before this commit, when the path did not exist, the local case returned None, while the remote case returned an empty string.

Moreover, this commit fixes the get_mount_point function, since it internally calls the follow_symlink. After this commit, the ad-hoc fix for the follow_symlink is not needed anymore.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (ad777bc) to head (c258e26). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/data/remotepath.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #542 +/- ## ========================================== - Coverage 69.95% 69.94% -0.01% ========================================== Files 87 87 Lines 10887 10885 -2 Branches 2549 2548 -1 ========================================== - Hits 7616 7614 -2 - Misses 2798 2799 +1 + Partials 473 472 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.