alpha-unito / streamflow

StreamFlow Workflow Manager
https://streamflow.di.unito.it
GNU Lesser General Public License v3.0
52 stars 13 forks source link

Support `stacked` storage in scheduling #552

Closed GlassOfWhiskey closed 1 week ago

GlassOfWhiskey commented 1 month ago

This commit adds support for storage mounts in stacked locations. When measuring hardware occupancy, bind mounts should be taken into account when propagating paths to the inner stacked locations (e.g., for Docker containers). This commit adds support for this feature.

In addition, this commit improves the calculation of resource occupancy for stacked locations, ensuring that reserved hardware is correctly computed for all the stack levels.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 68.47134% with 99 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (723bac0) to head (fcac29e). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/deployment/connector/container.py 61.44% 41 Missing and 23 partials :warning:
streamflow/core/scheduling.py 33.33% 20 Missing :warning:
streamflow/scheduling/scheduler.py 86.88% 2 Missing and 6 partials :warning:
streamflow/deployment/future.py 81.48% 2 Missing and 3 partials :warning:
streamflow/deployment/connector/base.py 50.00% 1 Missing :warning:
streamflow/deployment/connector/occam.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #552 +/- ## ========================================== - Coverage 70.10% 70.09% -0.02% ========================================== Files 87 87 Lines 10913 11011 +98 Branches 2265 2295 +30 ========================================== + Hits 7651 7718 +67 - Misses 2824 2850 +26 - Partials 438 443 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.