Closed GlassOfWhiskey closed 1 week ago
Attention: Patch coverage is 94.11765%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 70.42%. Comparing base (
a15474b
) to head (e26e49b
). Report is 2 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
streamflow/scheduling/scheduler.py | 93.75% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now that hardware resources are checked for thw whole stack of
Connector
objects, just locking on a singleCondition
related to the outermostConnector
is not enough to prevent race conditions. This commit ensures that aLock
object for eachConnector
in the stack is acquired prior to reserve or release resources during scheduling. Locks are always acquired and released in order, preventing deadlocks.In addition, this commit makes the
ConnectorWrapper
compatible with theFutureConnector
feature by extending theFutureAware
class.