search

alpha-unito / streamflow

StreamFlow Workflow Manager
https://streamflow.di.unito.it
GNU Lesser General Public License v3.0
52 stars 13 forks source link

Refactor `DataManager` class and fix local copy #587

Closed GlassOfWhiskey closed 4 days ago

GlassOfWhiskey commented 1 week ago

This commit refactors the DataManager to simplify the logic. In detail, it propagates the symbolic link logic directly to the Connector hierarchy instead of handling it explicitly in the DataManager level. In addition, it fixes same connector data movements to apply symbolic links when the file is read only.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (6db241d) to head (2f91fce). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/deployment/connector/base.py 75.00% 1 Missing and 1 partial :warning:
streamflow/deployment/connector/local.py 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #587 +/- ## ========================================== + Coverage 70.93% 71.05% +0.11% ========================================== Files 87 87 Lines 11066 11045 -21 Branches 1909 1905 -4 ========================================== - Hits 7850 7848 -2 + Misses 2765 2750 -15 + Partials 451 447 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.