alphaHeavy / protobuf

An implementation of Google's Protocol Buffers in Haskell.
http://hackage.haskell.org/package/protobuf
BSD 3-Clause "New" or "Revised" License
96 stars 18 forks source link

Import orphan Foldable Last instance from base-orphans #26

Closed RyanGlScott closed 8 years ago

RyanGlScott commented 8 years ago

GHC 8.0/base-4.9 adds a Foldable Last instance, which conflicts with the orphan instance defined in protobuf. This commit consolidates the orphan Foldable Last instance with the one in base-orphans so that on GHC 7.10 and earlier, it uses the instance from base-orphans, and on GHC 8.0 and later, it uses the one defined in base.

Note that now Data.ProtocolBuffers.Orphans is simply a reexport of Data.Orphans, but I kept it to avoid a breaking API change.

NathanHowell commented 8 years ago

lgtm, thanks! :+1: