search

alphaHeavy / protobuf

An implementation of Google's Protocol Buffers in Haskell.
http://hackage.haskell.org/package/protobuf
BSD 3-Clause "New" or "Revised" License
96 stars 18 forks source link

Cutting a new release (Orphan.hs issue) #29

Closed YoEight closed 8 years ago

YoEight commented 8 years ago

Greetings,

In my way to migrate my lib to GHC 8.0.1 I got this error.

    Configuring protobuf-0.2.1.0...
    Building protobuf-0.2.1.0...
    Preprocessing library protobuf-0.2.1.0...
    [1 of 8] Compiling Data.ProtocolBuffers.Orphans ( src/Data/ProtocolBuffers/Orphans.hs, .stack-work/dist/x86_64-linux/Cabal-1.24.0.0/build/Data/ProtocolBuffers/Orphans.o )

    /tmp/stack14565/protobuf-0.2.1.0/src/Data/ProtocolBuffers/Orphans.hs:17:1: error:
        Duplicate instance declarations:
          instance Foldable Last
            -- Defined at src/Data/ProtocolBuffers/Orphans.hs:17:1
          instance Foldable Last -- Defined in ‘Data.Foldable’

It appears that issue doesn't occur on protobuf master.

Is it possible to cut and upload a new release onto Hackage (and also indicating in Stackage repo protobuf builds with GHC 8.0.1) ?

Thanks for your time.

Yorick

YoEight commented 8 years ago

Any news on that front ?

NathanHowell commented 8 years ago

@YoEight the first notification got lost in my inbox over the holiday weekend, sorry about that. I will work on it either tonight or Monday morning.

YoEight commented 8 years ago

No problem, thank you very much !

NathanHowell commented 8 years ago

I backported these fixes to the 0.2 branch and cut a new release: http://hackage.haskell.org/package/protobuf-0.2.1.1

YoEight commented 8 years ago

Thanks, works for me