search

alphaHeavy / protobuf

An implementation of Google's Protocol Buffers in Haskell.
http://hackage.haskell.org/package/protobuf
BSD 3-Clause "New" or "Revised" License
96 stars 18 forks source link

Doesn't compile with GHC 8.8 #37

Closed HuwCampbell closed 4 years ago

HuwCampbell commented 4 years ago

There are calls to fail in Data/ProtocolBuffers/Wire.hs which don't comport to the MonadFail proposal.

I'm happy to have a look.

HuwCampbell commented 4 years ago

Looks like the latest version on hackage (protobuf-0.2.1.2) calls fail on PutM, but there are more recent commits on Github which would likely fix the issue.

I'd be happy to put up a patch commit over 0.2.1.2 to just fix it there if that's desirable.

NathanHowell commented 4 years ago

@HuwCampbell sorry, missed this in a sea of notifications. probably worth backporting, not sure if the breaking changes in 0.3 are worth releasing now

HuwCampbell commented 4 years ago

Ok, I'll try to find some time to put a patch together.

YoEight commented 4 years ago

Hi, I got a patch ready based on the tag v0.2.1.2: 63b28681ac879d9f58863a2bd4cc374f5144cb58. Could someone upload it to Hackage, I do not belong to the package's maintainer list.

NathanHowell commented 4 years ago

@YoEight I've added you as a maintainer on Hackage, release away! 🎉

YoEight commented 4 years ago

Thank you very much!

YoEight commented 4 years ago

Available on Hackage: https://hackage.haskell.org/package/protobuf-0.2.1.3

HuwCampbell commented 4 years ago

Ta