search

alphaHeavy / protobuf

An implementation of Google's Protocol Buffers in Haskell.
http://hackage.haskell.org/package/protobuf
BSD 3-Clause "New" or "Revised" License
95 stars 18 forks source link

Migrate from `type-level` lib to `GHC.TypeLits`. #7

Closed aloiscochard closed 10 years ago

aloiscochard commented 10 years ago

I did that change while upgrading to GHC 7.8.2.

According to the doc it's something you wanted to do anyway, so I hope it's fine the way I integrated GHC.TypeLits?

review by @NathanHowell (I suppose)

aloiscochard commented 10 years ago

I integrated that change in one of my project and all tests pass, not sure for travis but it's probably a matter of using the new GHC.

NathanHowell commented 10 years ago

The base lower bounds should be set to 4.7 I think, and the package would need a major version bump to (at least) 0.2.x.

Though I'm not sure what the best way to handle this sort of release is. Keep version 0.1 for GHC < 7.8 and restrict 0.2 to >= 7.8?

aloiscochard commented 10 years ago

@NathanHowell I agree about versioning, I started reworking on that and actually migrating the tests but unfortunately I got stuck when it comes to reify KnownNat, you might have an idea

I found some example but then they use SomeNat, so I haven't found yet a way make the tests work.

aloiscochard commented 10 years ago

After discussing with @copumpkin yesterday I think I see how to finish porting tests and finish that PR.

aloiscochard commented 10 years ago

Not sure why travis-ci don't detect the PR, I'll create a new one.