search

alphaHeavy / protobuf

An implementation of Google's Protocol Buffers in Haskell.
http://hackage.haskell.org/package/protobuf
BSD 3-Clause "New" or "Revised" License
96 stars 18 forks source link

Feature/typelits #8

Closed aloiscochard closed 10 years ago

aloiscochard commented 10 years ago

Here is the reworked version, this time everything compile and the tests pass except tagsOutOfRangeTests.

I'm not sure why those out of range tests fail, maybe it's related to the warnings about literal out of range? I tried to disable those one but no change.

It would be nice if someone more familiar with those specific tests look into, because it might be an obvious trivial change.

I believe it's ready for merging aside from that, what you think @NathanHowell ?

aloiscochard commented 10 years ago

(Not sure why Traivs keep failling, someone more familiar with it might be able to fix, I tried to give an explicit GHC version in the configuration.)

NathanHowell commented 10 years ago

Looks like Travis doesn't have 7.8 installed yet. The patch looks great though, thanks for fixing up the tests and docs. I'll upload a new release to Hackage this week.

aloiscochard commented 10 years ago

Awesome!

Ty for this great lib @NathanHowell