search

alphabit-technology / erpnext-restaurant

ERPNext Restaurant
GNU General Public License v3.0
111 stars 130 forks source link

Frappe v15 compatibility? #59

Open elvinmeza opened 2 months ago

elvinmeza commented 2 months ago

Is it possible to make it run over frappe v15? or any plans in the near future?

I've tried it but keep getting this error on the last step (migrate):

File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/utils.py", line 241, in load_doctype_module
    raise ImportError(msg) from e
      doctype = 'Desk Form'
      module = 'Frappe Helper'
      prefix = ''
      suffix = ''
      app = 'frappe_helper'
      key = ('frappe_helper', 'Desk Form', '', '')
      module_name = 'frappe_helper.frappe_helper.doctype.desk_form.desk_form'
      msg = "Module import failed for Desk Form, the DocType you're trying to open might be deleted.<br> Error: cannot import name 'get_max_file_size' from 'frappe.core.doctype.file.file' (/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py)"
builtins.ImportError: Module import failed for Desk Form, the DocType you're trying to open might be deleted.<br> Error: cannot import name 'get_max_file_size' from 'frappe.core.doctype.file.file' (/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py)

any thoughts? thanks in advance!

alphabit-technology commented 2 months ago

The version of the develop branch is compatible with frappe 15, this version no longer needs the frappe helper app.

It is pending review to send to production, but you can try it if you want.

elvinmeza commented 2 months ago

That's great news! Thanks @alphabit-technology I'll give it a try.

elvinmeza commented 2 months ago

Hey @alphabit-technology It worked using the develop branch, but the layout objects (excluding rooms) didn't render in the UI. Any thoughts? Thanks!

Screenshot 2024-05-11 at 10 24 13 AM
alphabit-technology commented 2 months ago

Can you give me access to your server?

elvinmeza commented 2 months ago

Hi @alphabit-technology apologies for the late reply and thanks for your prompt responses. I'll try to coordinate the access, in the meantime if you can point me out in the right direction on what to check or do I can give it a try. Thanks for your help!

seifkh97 commented 1 month ago

Hello, can you help me install the develop branch on my erpnext 15 what command should i write? thank you all

elvinmeza commented 3 weeks ago

@seifkh97 just use the branch command parameter to install the develop branch https://frappeframework.com/docs/user/en/bench/resources/bench-commands-cheatsheet#development

alphabit-technology commented 3 weeks ago

Let me get back to the development and we will be in touch.