search

alphacep / ros-vosk

Vosk node for ROS Robot Operating System
Apache License 2.0
37 stars 19 forks source link

configure model without changing source code #9

Closed v4hn closed 1 year ago

v4hn commented 1 year ago

I was pretty surprised that you have to edit the source code of this node in order to use it because otherwise it will check for whether ros_vosk/models/None exists and it obviously doesn't.

This patch provides a more reasonable behavior to look for the requested model to decide whether or not it needs to start the download gui.

nshmyrev commented 1 year ago

Thank you! Btw, you can load model just by name (it downloads automatically) not necessary path.

v4hn commented 1 year ago

you can load model just by name (it downloads automatically) not necessary path.

Can you elaborate? I guess at the moment it will always open the GUI if the model does not exist. But if the user could set a custom model folder (e.g., $HOME/.cache/ros-vosk) and the system would download a chosen model automatically when it's not available there, that would be quite useful.