search

alphagov / calculators

Serves the Child benefit tax calculator on GOV.UK
https://docs.publishing.service.gov.uk/apps/calculators.html
MIT License
11 stars 13 forks source link

Remove redundant config #1015

Closed ChrisBAshton closed 3 years ago

ChrisBAshton commented 3 years ago

The sassLint option was removed in https://github.com/alphagov/govuk-jenkinslib/pull/80 And the Yarn install step is unnecessary as of https://github.com/alphagov/govuk-jenkinslib/pull/82

ChrisBAshton commented 3 years ago

Change looks good - seems like there's an unrelated test failure, which hopefully just needs a re-run for it to pass on this particular PR.

If only it were that simple! Calculators has been failing since 2021, despite use of Travelcop in the tests. I had a go at fixing it a couple of weeks ago but didn't get very far, so have raised a Platform Health card for it: https://trello.com/c/zY7Ulj8Y/2016-fix-tests-in-calculators

I've added an AC to that card that all open PRs (including this one) are merged as part of that work.

ChrisBAshton commented 3 years ago

Superseded by #1026.