search

alphagov / cyber-security-concourse-base-image

1 stars 3 forks source link

Add pyenv #36

Closed akinnane closed 3 years ago

akinnane commented 3 years ago

See https://github.com/alphagov/centralised-security-logging-service/issues/380

akinnane commented 3 years ago

See https://github.com/alphagov/centralised-security-logging-service/pull/386

akinnane commented 3 years ago

What does this leave as the default global python/python3? This images is used in a lot of places if the default python version changes.

The default stays as it was. pyenv is only used when manually selected or requested via a .python-version file. Screenshot from 2021-02-11 12-51-15

danjoneslf commented 3 years ago

Does that mean the pip version for other things using that default 3.7.5 won't have changed? I'm reasonably sure we've used cryptography elsewhere. Should we use pyenv to install 3.7.5 and set pyenv global?

akinnane commented 3 years ago

That's a good idea. I've tested it, it works, and I've committed the change.

Screenshot from 2021-02-11 13-13-07

akinnane commented 3 years ago

It works for venvs too. Screenshot from 2021-02-11 13-20-15