search

alphagov / cyber-security-security-advisory-dashboard

A web dashboard surfacing the state of github security advisories across our estate
MIT License
8 stars 6 forks source link

[DO NOT MERGE] Upgrade version of `graphql-core` to >3.0.0 without breaking `github_security` audit events ^ #603

Open gds-ahine opened 3 years ago

gds-ahine commented 3 years ago

This shouldn't be merged until we can also upgrade to gql:3 currently in alpha

Dependabot alert to bump the version of graphql-core broke the github audit events.

We reverted back to <3.0.0 but we should look into upgrading to resolve the following issues -:

https://github.com/alphagov/cyber-security-security-advisory-dashboard/pull/572

https://github.com/graphql-python/graphql-core/issues/125 https://github.com/graphql-python/graphql-core/issues/126

danjoneslf commented 3 years ago

Unfortunately we can't implement this at present. The gql library calls a function of graphql-core which has been removed in later versions. There is an equivalent function in 3.* releases but there's not yet a newer release of gql implementing the change.

There is an alpha of gql:3 which addresses this: https://github.com/graphql-python/gql/issues/62 - In alpha in Sep 2020