Closed andysellick closed 1 year ago
@MartinJJones is this possibly related to the recent application.scss compiling work that we talked about recently?
@andysellick yes, this PR will fix this issue as well - https://github.com/alphagov/govuk_publishing_components/pull/3347
@andysellick just wanted to confirm this issue was fixed in version 35.3.4 of the publishing components gem, screenshot below:
One thing to note, is that the content within the expander component does not have any styling, as shown below:
This appears to be expected given the contents shown:
This is some content that is passed to the component. It should be distinct from the component, in that the component should not style or interact with it, other than to show and hide it.
I was thinking I could either close this issue with the current styling, or I could update the YML file to include some basic styling for the text before closing this issue, what do you think?
@MartinJJones just tested and yep, all fixed, great stuff.
Don't worry about the styling - it shouldn't be styled, and the message I think is clear enough.
Logging this last thing on a Friday in case I forget. I just noticed that the components in
finder-frontend
don't appear to be rendering properly in the component guide (see below), although they seem to be okay in the rest of the application.I've only been able to test this locally as the live
finder-frontend
component guide isn't online at the moment.e.g. the expander component: