alphagov / finder-frontend

Serves finder and search pages for GOV.UK
https://docs.publishing.service.gov.uk/apps/finder-frontend.html
MIT License
20 stars 6 forks source link

Application components not rendering correctly #3047

Closed andysellick closed 1 year ago

andysellick commented 1 year ago

Logging this last thing on a Friday in case I forget. I just noticed that the components in finder-frontend don't appear to be rendering properly in the component guide (see below), although they seem to be okay in the rest of the application.

I've only been able to test this locally as the live finder-frontend component guide isn't online at the moment.

e.g. the expander component:

Screenshot 2023-04-28 at 16 07 00

andysellick commented 1 year ago

@MartinJJones is this possibly related to the recent application.scss compiling work that we talked about recently?

MartinJJones commented 1 year ago

@andysellick yes, this PR will fix this issue as well - https://github.com/alphagov/govuk_publishing_components/pull/3347

MartinJJones commented 1 year ago

@andysellick just wanted to confirm this issue was fixed in version 35.3.4 of the publishing components gem, screenshot below:

Screenshot 2023-05-22 at 14 07 42

One thing to note, is that the content within the expander component does not have any styling, as shown below:

Screenshot 2023-05-22 at 15 41 11

This appears to be expected given the contents shown:

This is some content that is passed to the component. It should be distinct from the component, in that the component should not style or interact with it, other than to show and hide it.

I was thinking I could either close this issue with the current styling, or I could update the YML file to include some basic styling for the text before closing this issue, what do you think?

andysellick commented 1 year ago

@MartinJJones just tested and yep, all fixed, great stuff.

Don't worry about the styling - it shouldn't be styled, and the message I think is clear enough.