search

alphagov / gds-tech-learning-pathway

Guidance on learning and development for GDS Technologists
Other
10 stars 5 forks source link

Add code reviews doc #111

Closed KyleMacPherson closed 6 years ago

KyleMacPherson commented 6 years ago

Add a code review doc with a brief explanation of what a code review is and why we do them.

Add some (hopefully!) useful tips for reviewing code and having code reviewed and links that I found useful in writing this.

NickColley commented 6 years ago

Non-blocking: It would be nice to include some of Alex's points around collaboration in this http://www.alexandra-hill.com/2018/06/25/the-art-of-giving-and-receiving-code-reviews/ as pairing is often a great way to resolve difficult code reviews.

KyleMacPherson commented 6 years ago

Good idea @nickcolley. I actually cited that article in the resources list as I found it really interesting and insightful but the it felt like something I could not do justice to within this format.

chao-xian commented 6 years ago

Awesome stuff @KyleMacPherson 👏