search

alphagov / government-frontend

Serves government pages on GOV.UK
https://docs.publishing.service.gov.uk/apps/government-frontend.html
MIT License
53 stars 17 forks source link

Organisation logo when link is organisation colour #1487

Closed injms closed 3 years ago

injms commented 5 years ago

When an organisation logo has a link around it, it is displayed using the department colours when focused and unfocused:

Screen Shot 2019-09-16 at 14 05 49 Screen Shot 2019-09-16 at 14 05 32

Example taken from the About page for DCMS

The expected behaviour in both cases is for the text to be black.

andysellick commented 5 years ago

@injms dang it, I thought this would be fixed by https://github.com/alphagov/govuk_publishing_components/pull/1088, I'll take another look.

andysellick commented 5 years ago

This is a wider problem than just the logo - it happens on almost every link on this page (although not all of them, oddly). It's caused by an overriding nested class to set the link colour, which also happens on other organisation pages. We need to address this as the root cause of the problem.

Most of the components used on these pages have a branding option, but it's not going to be a small piece of work - we need to check they're all turned on, add it for those that don't have it, then remove all the page override classes.

owenatgov commented 3 years ago

Made redundant by https://github.com/alphagov/government-frontend/pull/2129 Closing!