alphagov / government-frontend

Serves government pages on GOV.UK
https://docs.publishing.service.gov.uk/apps/government-frontend.html
MIT License
54 stars 17 forks source link

Duplicate print this page button in guidance publications #1907

Closed alex-ju closed 2 years ago

alex-ju commented 4 years ago

We show two instances of the 'print this page' button which overlap at a certain scroll position.

Page example: https://www.gov.uk/government/publications/actions-for-schools-during-the-coronavirus-outbreak/guidance-for-full-opening-schools

Visual example

2020-11-09 at 13 16 14

alex-ju commented 3 years ago

The same issue causes overlap with the feedback component further down the page.

Screenshot 2021-02-24 at 10 22 10
DilwoarH commented 3 years ago

Raised again on: https://github.com/alphagov/govuk_publishing_components/issues/1970

DilwoarH commented 3 years ago

I will speak with the designer to see if we can come up with a solution

danacotoran commented 3 years ago

For whoever gets round to fixing this, it can be reproduced by:

  1. clearing cookies so that you see the cookie banner at the top
  2. either accept/reject cookies – choice doesn't matter, what matters is that the cookie banner changes state

Now if you scroll down to the bottom of the feedback banner you would be able to see the issue Alex shows here.

Thought I'd document this in the issue.

DilwoarH commented 3 years ago

Thanks for this @danacotoran - I have spoken with the interaction designer who worked on the original work with me and we've come up with a few solutions that might solve the problem.

DilwoarH commented 3 years ago

@alex-ju @chris-gds @danacotoran - I spoke to the designer who was originally working with me on this and we came to the conclusion that item lists longer than 10 would create duplicates in different screen sizes. Please have a look at the PR that I raised: https://github.com/alphagov/government-frontend/pull/2056

andysellick commented 2 years ago

Closing as this page has been changed to not have a duplicate button: https://github.com/alphagov/government-frontend/pull/2493