Fix publication attachments - Githubissues

alphagov / government-frontend

Serves government pages on GOV.UK

https://docs.publishing.service.gov.uk/apps/government-frontend.html

MIT License

52 stars 17 forks source link

Fix publication attachments #3159

Closed andysellick closed 5 months ago

andysellick commented 5 months ago

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

simplify and fix the code to display attachments on publication/form pages
move most of the code into the presenter, to reduce ambiguity
pass only one thing to the attachments_list component
update tests

Follows on from the work done in https://github.com/alphagov/government-frontend/pull/3058

Why

Recent changes to rendering of publication attachments were not fully correct, as reported in zendesk ticket https://govuk.zendesk.com/agent/tickets/5807151 and elsewhere.

Specifically:

attachments on https://www.gov.uk/government/publications/further-education-workforce-data-collection should not be marked as inaccessible, so the option to request an accessible format should not be shown
attachments on https://www.gov.uk/government/publications/dvsa-vision-to-2030 were not marked as HTML where they should be

Visual changes

See 'why'.

Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments