Fix publication external links - Githubissues

alphagov / government-frontend

Serves government pages on GOV.UK

https://docs.publishing.service.gov.uk/apps/government-frontend.html

MIT License

50 stars 17 forks source link

Fix publication external links #3160

Closed andysellick closed 3 months ago

andysellick commented 3 months ago

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

some attachments are simply links to another website
for these we need to identify the type as 'external' and pass the right option to the attachment component
added test for this

Why

Pages like this were showing external links as HTML attachments: https://www.gov.uk/government/publications/national-risk-register-2023

Visual changes

External links should now look like this:

Screenshot 2024-04-18 at 14 52 54

Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments