Output attachments in consultation pages using the data from the content item, rather than the pre-rendered markup from the content item, and apply GA4 tracking to those attachments that contain Details elements.
Attachments on consultation pages can occur in three places, so this is a bit more complex than publications, although some of the code and tests have been copied from that previous work.
Note: an interesting side point on margin - there's some code for logic around a margin to appear beneath boxes that appear at the top of in-progress consultations ('We are analysing your feedback') so that spacing is only applied if there's stuff beneath it. Pretty sure I've preserved the logic but worth checking.
Why
This work is for two reasons:
to convert the rendering of attachments to using components so that tracking can be added to Details elements within attachments (for the 'Request an accessible format' element)
to generally move away from the use of pre-rendered markup passed through content items
Visual changes
Mostly should be no visual changes, however this change does remove custom thumbnails for PDFs (as previously removed for publications). This has been agreed and widely discussed around the previous work.
Thanks @KludgeKML yes definitely something to consider once all the formats have been converted. There's certainly a lot of duplication here now, particularly in the tests.
⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️
What
Output attachments in consultation pages using the data from the content item, rather than the pre-rendered markup from the content item, and apply GA4 tracking to those attachments that contain Details elements.
This follows on from the work to convert publications in the same manner: https://github.com/alphagov/government-frontend/pull/3058
Attachments on consultation pages can occur in three places, so this is a bit more complex than publications, although some of the code and tests have been copied from that previous work.
Example pages to test with:
Note: an interesting side point on margin - there's some code for logic around a margin to appear beneath boxes that appear at the top of in-progress consultations ('We are analysing your feedback') so that spacing is only applied if there's stuff beneath it. Pretty sure I've preserved the logic but worth checking.
Why
This work is for two reasons:
Visual changes
Mostly should be no visual changes, however this change does remove custom thumbnails for PDFs (as previously removed for publications). This has been agreed and widely discussed around the previous work.
Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments