alphagov / government-frontend

Serves government pages on GOV.UK
https://docs.publishing.service.gov.uk/apps/government-frontend.html
MIT License
51 stars 17 forks source link

Make contact_for_office tolerant of missing data #3276

Closed richardTowers closed 1 day ago

richardTowers commented 1 month ago

NOTE: not sure this is the right thing to do - we should probably fix the data in content-store rather than patching the frontend to be tolerant of bad data. Raising this as a suggestion.

Worldwide organisation content items should have both office_contact_associations and a link to contacts.

If they don't have both, we can either error (what the code used to do), or just skip the contact section (what this PR does).

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️