search

alphagov / government-service-design-manual

Government Service Design Manual
https://www.gov.uk/service-manual
Other
200 stars 168 forks source link

Update progress indicator pattern #603

Closed timpaul closed 9 years ago

timpaul commented 9 years ago

We've updated the guidance given here so that it better reflects what we've been telling service teams recently.

cjforms commented 9 years ago

This pull request is a much-needed update of our advice on progress indicators that takes account of research over the last 18 months. Please merge.

issyl0 commented 9 years ago

Hi @timpaul. These changes look good, though would you mind squashing these three commits together so as to have clean history, perhaps with the commit message "Update progress indicator pattern guidance", as these three commits are slight changes and syntax fixes each time with the same goal. If you need a hand, http://stackoverflow.com/a/6934882 hopefully makes sense, but if it doesn't, I'm around to help, or I could do it for you (though maybe you wouldn't take too kindly to that - I don't know). You'll need to git push -f origin update_progress_indicator_pattern afterwards to get the changes back onto GitHub, and this PR will auto-update.

issyl0 commented 9 years ago

I've just rebased this branch and squashed the three commits into one in preparation for merging. :+1:

joelanman commented 9 years ago

thanks @issyl0 !

timpaul commented 9 years ago

Thanks @issyl0 - sorry I didn't get around to it myself. Does that mean it'll be next Thursday now when it goes live?