search

alphagov / govuk-browser-extension

Chrome and Firefox extension for developers working on GOV.UK.
25 stars 5 forks source link

Can't view individual 'help/' and 'done/' pages #40

Closed davidbasalla closed 7 years ago

davidbasalla commented 7 years ago

When viewing the content item for a specific help page (eg https://www.gov.uk/help/about-govuk) it shows the 'special route' entry for the '/help' slug, but not content item for '/help/about-govuk'.

For done pages (eg https://www.gov.uk/done/pay-dvla-fine), viewing the content item returns a 404.

Davidslv commented 7 years ago

@davidbasalla I've have fixed the https://www.gov.uk/done/pay-dvla-fine here: https://github.com/alphagov/govuk-toolkit-chrome/pull/39

Have you updated your plugin recently? Or are you saying there's still a bug? Or maybe this fix is not in the Chrome Extensions yet? @tijmenb ?

davidbasalla commented 7 years ago

Ah nice, hadn't seen that, but yeah currently it does not work in my browser. I wasn't aware I had to update the plugin myself? Granted I don't know anything about how Chrome extensions work :/

From the code in https://github.com/alphagov/govuk-toolkit-chrome/pull/39 it looks like only 'done' pages are supported. 'help' pages would probably need the same fix? Happy to add it in myself of course!

tijmenb commented 7 years ago

Closed via https://github.com/alphagov/govuk-toolkit-chrome/pull/42.