search

alphagov / govuk-browser-extension

Chrome and Firefox extension for developers working on GOV.UK.
22 stars 5 forks source link

Add function to outline GOV.UK components on page #79

Closed tomsabin closed 6 years ago

tomsabin commented 6 years ago

We hope to encourage re-use of design elements that are documented in the component guides [1][2] by highlighting where they exist in the page.

The user can toggle this functionlity on from the extension popup, which will outline all the components in the page with a label of what it is called. Clicking within the outline will navigate the user to its documentation.

[1] https://govuk-static.herokuapp.com/component-guide [2] https://government-frontend.herokuapp.com/component-guide

out

fofr commented 6 years ago

So cool ❤️

NickColley commented 6 years ago

This is very coooooool 👍

alextea commented 6 years ago

What are the reasons for putting the labels on the right? Did you try the labels on the left?

They might be non-obvious as they are out of people's eye line.

huminmiah commented 6 years ago

Good point @alextea. I think having labels on the left hand side would cover up key parts of smaller components? for example the print link in government-frontend. Worth looking into this more though.

Also, it's not obvious that the highlighted parts of the page are clickable and link to the component guide.

Awesome progress! great MVP :)

fofr commented 6 years ago

@alextea Labels on the left are more likely to cover text/part of a component. But I don't think it matters much either way.

tomsabin commented 6 years ago

@fofr @nickcolley I believe all the comments above have been resolved. Can we request a final review?