search

alphagov / govuk-browser-extension

Chrome and Firefox extension for developers working on GOV.UK.
22 stars 5 forks source link

Highlight components feature should only appear on www.gov.uk #85

Closed tijmenb closed 6 years ago

tijmenb commented 6 years ago

This extension works on content pages (www.gov.uk/) and .publishing.service.gov.uk domains. On the latter we shouldn't show the highlight components feature (https://github.com/alphagov/govuk-toolkit-chrome/pull/79) because it wouldn't do anything:

screen shot 2017-10-05 at 08 49 10

rubenarakelyan commented 6 years ago

This logic would also break the feature on non-production environments. Is there a good way to differentiate between backend apps and non-production frontend apps? Maybe look for www or www-origin?

tijmenb commented 6 years ago

I think we do that here:

https://github.com/alphagov/govuk-toolkit-chrome/blob/ac49f9df63c521aa48373c5e8dacd3c8fc6831a0/src/popup/environment.js#L59

tijmenb commented 6 years ago

We shouldn't do this anymore, because one day we'll use the components in the backend too! Closing.