alphagov / govuk-country-and-territory-autocomplete

An autocomplete widget that uses data from Country and Territory Register.
https://alphagov.github.io/govuk-country-and-territory-autocomplete/examples/
MIT License
36 stars 18 forks source link

Add definition, support content, links to README #101

Closed EoinShaughnessy closed 2 years ago

EoinShaughnessy commented 2 years ago

Fixes #23 and #562.

This PR updates the country-and-territory-autocomplete README with:

EoinShaughnessy commented 2 years ago

We also need to replace the placeholder links with the real links for the research and support issues.

EoinShaughnessy commented 2 years ago

@lfdebrux I made a mistake when I tried to rebase. If it's ok, can I get your help sometime getting back to where I was before rebasing?

EoinShaughnessy commented 2 years ago

The 'Reopen pull request' button below is greyed-out, so I guess that's not an option...is it?

lfdebrux commented 2 years ago

@EoinShaughnessy Ah, I think when you rebased you may have ended up dropping your changes by accident, which made GitHub think that the PR had no new changes and had already been merged! 😕 No worries, we can sort it, although we might have to open a new PR.

Getting back to the old state is fairly easy, GitHub helpfully tells you now what the commit id was before a rebase was done:

@EoinShaughnessy EoinShaughnessy force-pushed the update-readme branch from 5a6fb33 to 1ebec65 1 hour ago

So to reset things to the way they were before you can use the commands

git checkout update-readme
git reset --hard 5a6fb33
git push --force-with-lease origin update-readme
EoinShaughnessy commented 2 years ago

@calvin-lau-sig7 Can I get a final review? :)