search

alphagov / govuk-country-and-territory-autocomplete

An autocomplete widget that uses data from Country and Territory Register.
https://alphagov.github.io/govuk-country-and-territory-autocomplete/examples/
MIT License
38 stars 18 forks source link

Update accessible-autocomplete to 2.0.3 #107

Closed oscarduignan closed 2 years ago

oscarduignan commented 2 years ago

In the alphagov/accessible-autocomplete library a span was being used as a wrapper where a div was needed instead, this invalid html is getting flagged by automated tests tests with VNU from HMRC services consuming this library so I've raised this PR. I can see that there are a lot of changes since last release was cut but couldn't see anything listed in the unreleased section on github so have assumed that those were just dev related bits and it would be ok to bump the version. I did some sanity checks manually locally which raised no problems post update, and both versions of accessible-autocomplete this change upgrades through are listed as having no breaking changes in it's changelog

Fixes alphagov/govuk-country-and-territory-autocomplete#69

36degrees commented 2 years ago

Thanks for raising this @oscarduignan – we've since released v2.0.4 of the accessible-autocomplete and have raised and merged #108 to update to that version.

On that basis I'm going to close this PR.

oscarduignan commented 2 years ago

many thanks @36degrees 🙌