search

alphagov / govuk-country-and-territory-autocomplete

An autocomplete widget that uses data from Country and Territory Register.
https://alphagov.github.io/govuk-country-and-territory-autocomplete/examples/
MIT License
38 stars 18 forks source link

Update picker to autocomplete #24

Closed dankmitchell closed 7 years ago

dankmitchell commented 7 years ago

This repo is backed by the accessible autocomplete so therefore picker isn’t the write terminology.

@J-Lambo can I get some input please

J-Lambo commented 7 years ago

Looks sensible to me!

dankmitchell commented 7 years ago

Is that a seal of approval @J-Lambo ? 🤓

dankmitchell commented 7 years ago

If there are no more comments, can I get an approval @edwardhorsford @J-Lambo @nickcolley ?

edwardhorsford commented 7 years ago

I've not tested the changes, but I approve of the changes in principle.

I didn't know it was the GOV.UK Registers (not GDS team) - should this be in a separate PR anyway?