alphagov / govuk-country-and-territory-autocomplete

An autocomplete widget that uses data from Country and Territory Register.
https://alphagov.github.io/govuk-country-and-territory-autocomplete/examples/
MIT License
38 stars 18 forks source link

Process for importing data is broken #44

Open MatMoore opened 6 years ago

MatMoore commented 6 years ago

When following the instructions in CONTRIBUTING.md to update the data, I noticed that the generated graph doesn't include all the names in the existing JSON (possibly all the synonyms have been removed). Meaning that we can't just update the data by running this script.

Turns out there used to be another thing, https://github.com/openregister-attic/kibitz which originally generated these files. This also includes additional synonyms that are not part of the registers themselves. This was then replaced by https://github.com/openregister/generate-picker-data-file (the lambda function we're calling here). This has outstanding issues that need to be addressed, for example https://github.com/openregister/generate-picker-data-file/issues/11

In the short term, I can work around this, but I'm raising this issue just to acknowledge that the instructions are misleading and we (the register team) need to fix it.