search

alphagov / govuk-country-and-territory-autocomplete

An autocomplete widget that uses data from Country and Territory Register.
https://alphagov.github.io/govuk-country-and-territory-autocomplete/examples/
MIT License
36 stars 18 forks source link

default onSelect handler compares option innerText with result.name, … #6

Closed revilossor closed 7 years ago

revilossor commented 7 years ago

With a select like this...

<select name="response" id="openregister-picker">
    <option value="territory:AE-AJ">Ajman</option>
    <option value="territory:AS">American Samoa</option>
    ....other options....
</select>

...and initialisation like this...

var openregisterPicker = document.querySelector('#openregister-picker');
if(!!openregisterPicker) {
  openregisterLocationPicker({
    selectElement: openregisterPicker,
    url: openregisterPicker.dataset.graph
  });
}

...nothing is selected when i choose an option.

This changes the default onSelect handler to fix this.

revilossor commented 7 years ago

Yep, there you go

tvararu commented 7 years ago

Thanks @revilossor! Please do submit more bugs / fixes for things that you find. 🙌

tvararu commented 7 years ago

Published in v0.1.0!