alphagov / govuk-design-system-backlog

GOV.UK Design System Community Backlog
28 stars 2 forks source link

Typography #64

Open govuk-design-system opened 6 years ago

govuk-design-system commented 6 years ago

Use this issue to discuss typography in the GOV.UK Design System, including links and lists.

ignaciaorellana commented 6 years ago

Idea: include ideas on what to do when you can't use Transport font

torydunn-hmrc commented 5 years ago

The style of having a smaller heading above the H1 shouldn't be called a "caption," which is used in publishing to mean the information associated with an image or non-text item. I'd suggest calling it a supraheading, which describes it's relationship to the H1.

jennifer-hodgson commented 5 years ago

Hi folks. Have been discussing "captions" versus "secondary headings" versus "supraheadings" with @stevenaproctor, and he suggested that what we gain in clarity with "supraheading" we lose in terms of Plain English. We suggest "section heading"...? Descriptive of what it's used for, easy to understand... Thoughts?

torydunn-hmrc commented 5 years ago

Seems like a good iteration to me. Thanks.

On 6 August 2018 at 10:31, Jennifer Hodgson notifications@github.com wrote:

Hi folks. Have been discussing "captions" versus "secondary headings" versus "supraheadings" with @stevenaproctor https://github.com/stevenaproctor, and he suggested that what we gain in clarity with "supraheading" we lose in terms of Plain English. We suggest "section heading"...? Descriptive of what it's used for, easy to understand... Thoughts?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alphagov/govuk-design-system-backlog/issues/64#issuecomment-410647536, or mute the thread https://github.com/notifications/unsubscribe-auth/Aildwmuaj-7g3mLzCnnDxLgFAjZbbFUkks5uOA0JgaJpZM4RchTM .

-- Tory Dunn

Head of Design | CDIO Digital Services | Dorset House | 07392 289160

timpaul commented 5 years ago

An issue has been raised in the past about the 'link ink skipping' feature in modern browsers:

image

There's a concern that this causes some users to see single links as multiple links, and that is this a problem. Does anyone have any evidence to support this? If so, please comment here, or on this issue.

36degrees commented 5 years ago

There's an interesting thread on ink skipping on Twitter here.

stevenaproctor commented 5 years ago

@timpaul People have commented that the "Births, deaths, marriages and care" link on the GOV.UK frontpage looks like 3 links because the commas make it look like the link has ended.

The underline definitely makes q, y, g, j, commas and other descenders harder to read. I think this is true for all users and may contribute to why some sites do not have underlines.

There are situations where the ink skipping can cause people to read the link differently. There is an example in the Twitter thread @36degrees linked to of 9.9 or 99 percent. This kind of confusion would definitely cause problems if someone misreads an amount of money or percentage.

antondrachuk commented 5 years ago

Idea: include ideas on what to do when you can't use Transport font

Styles->Typography includes: “You should use an alternative typeface like Helvetica or Arial for services that are publicly available on different domains.” — are those the best alternatives in terms of accessibility? Especially when it comes to small sizes? At least one person suggests they might not be. There's also a pretty interesting comment thread there.

Some free typefaces that come to mind that are probably more readable would be something like Fira Sans, PT Sans or Source Sans.

chaslinn commented 5 years ago

I have been looking at the H1 and H2 styles in the prototyping kit recently and their apparent difference to the front end implementation (as far as I can see).

Just focusing on the H1 in the prototyping kit, I can see that the effective space below the H1 (50) is greater than the space above the H1 (either 30 or 40 depending on whether a Back link is present).

In live it is 30 below I believe. It is also possible to created similar situations for H2s in the prototyping kit where there is more space below than above the heading.

Theoretically there should always be less space below the heading than above, whatever the heading (H1, H2 or H3), as the content and heading need to be obviously visually associated.

It is possible that further guidance (to interaction designers) is required to make this happen with available styles or that the styles should be updated to achieve this affect. The desired effect can be achieved with override codes but we do not want to be overriding default behaviour I don't think.

In terms of importance of this issue, I would say it is greatly important that headings and hierarchical relationships are immediately understandable to a casual eye to avoid confusion and misunderstanding and that this potentially affects every page in a prototype, so for me high priority.

dashouse commented 5 years ago

Hi @chaslinn,

Thanks for your comment and your desire for good web typography :) Hopefully I will be able to give you a response to all of your questions. Let me know if anything isn't clear.

Frontend vs Prototype kit

Regarding "live" and "frontend" – It really depends what you mean by those terms. In terms of the GOV.UK Design System, GOV.UK Prototype Kit and GOV.UK Frontend, they all use the same rules. If you are referring to GOV.UK itself then spacing has been applied in many different ways across all of the individual rendering apps. You'll find completely different values, applied in different ways from page to page.

The spacing defined in GOV.UK Frontend (and therefore the Design System and Prototype Kit) was an attempt to systemise the typography and create a single way to do things.

I wrote a blog about this which I think will help give you some more context, even if the technical implementation is out of date. In this case check out the first image on to see just a few of the variants on just a few pages of GOV.UK.

General spacing rules

Regarding "Theoretically there should always be less space below the heading than above, whatever the heading (H1, H2 or H3), as the content and heading need to be obviously visually associated."

If we initially focus on Typography as a whole, this is what we're doing. We have a rule that "margin should flow in one direction", however to make sure there is more space below the heading (on every H level) than above then we have the concept of contextual adjustments.

This means h2, h3, h4, paragraphs, although only having margin-bottom when used on their own will actually have padding-top added in certain scenarios automatically.

For example: The h2, when following a lead paragraph has padding-top applied as a contextual adjustment.

screen shot 2018-11-20 at 12 49 52

If I zoom out and show you an example of using lots of heading levels, paragraphs and lists you'll see that these rules are in place for every level. Providing that there is nothing stopping the adjacent sibling selectors from working such as wrapping text inside <div>'s.

screen shot 2018-11-20 at 12 53 27

We have a great amount of consideration to the typographic hierarchy, making sure these relationships stay intact when the font size changes at the smaller breakpoints too. However there are some scenarios where a designer should make their own adjustments using overrides.

Page structure / Layout

Hopefully the above addresses the h2 and below, however you brought up an interesting point about the h1 and it's position on the page.

There was a couple of things at play here, we wanted text to start in the same position (give or take 5px) as it does on GOV.UK even though the margin and padding is applied in a different way.

For this we wanted to achieve an visually equal space (this may be technically slightly off) between the top of the heading and the start of the content below rather than having more space on top.

One thing you may not be aware of is the new way the page is structured.

Taking these from the Layout section of the Design System - https://design-system.service.gov.uk/styles/layout/ you can see that the spacing above the h1 comes from a wrapper called govuk-main-wrapper. This allows all content inside the grid to line up, rtaher than defining this on the h1 itself.

screen shot 2018-11-20 at 12 51 24

This should look like this:

screen shot 2018-11-20 at 12 50 29

When there is no back link, breadcrumbs or phase banner then there is a modifier to the govuk-main-wrapper class called govuk-main-wrapper--l. This actually increases the padding to make up for the space lost.

screen shot 2018-11-20 at 12 51 33

When applied this should look like this:

screen shot 2018-11-20 at 12 50 59

If you feel that what you're seeing in these screenshots is not how the typography is rendering in your app then we might be able to help find out why. Otherwise, I hope that at least explains some of the decisions we've made.

Dave

stevenaproctor commented 5 years ago

@dashouse I created a page in the prototype to demonstrate what @chaslinn is saying. This uses all the standard code from the Design System.

image

This means the H2 is always the same distance away from the form-group above it as it is from the form-group below it.

In your example content 1, the first paragraph is further away from the H1 than it is from the H2. The same is true in this example as well.

dashouse commented 5 years ago

Hey @stevenaproctor, sorry the original comment didn't mention headings as part of labels and legends. My answers, although relevant were largely based around text based content and didn't mention forms.

This particular problem with styling labels and legends as headings is that the heading needs to work in in context with the hint, error and the form element, locked in as one group inside a component. It also needs to have the same spacing applied so regardless if the heading is a legend or a label it looks the same.

For example the "Passport number" and "Expiry date" questions below:

screen shot 2018-11-20 at 13 56 19

We spent a number of weeks trying to find an automatic solution for some of the problems you have raised, we have a test scenario for the ways in which labels, legends and headings can be applied which has over 100 possible combinations.

To show just one scenario, here you see the spacing relationship between each potential element in the checkboxes component. As the heading changes size the relationship between the hint and error also changes.

screen shot 2018-11-20 at 14 01 00

Ideally, we would be able to adapt the spacing of the heading if a hint has not been entered, or if an error message isn't visible, however really pushing the limits of what we can achieve with SCSS and the Nunjucks macro.

In regards to form design this is the perfect scenario to use the override classes. They aren't intended as a last resort, but a way to adapt the defaults to your specific context.

For example, if you know you don't have any hints in your questions, you could override the margin so that the white space is equivalent to the hint just being invisible, rather than the block not being there at all.

We feel that this is where the Interaction Designer on each team will be able to make the best decisions for the particular question or service.

Perhaps we could include a few more examples on the question page pattern, showing how we'd use the overrides in specific scenarios?

stevenaproctor commented 5 years ago

@dashouse

This particular problem with styling labels and legends as headings is that the heading needs to work in in context with the hint, error and the form element, locked in as one group inside a component. It also needs to have the same spacing applied so regardless if the heading is a legend or a label it looks the same.

I totally agree that they should be considered a unit. If you remove the govuk-label--m and govuk-fieldset__legend-m classes in my example, the spacing stays the same. This is exactly what I would expect to happen in that label or legend, hint, error, input unit.

In regards to form design this is the perfect scenario to use the override classes. They aren't intended as a last resort, but a way to adapt the defaults to your specific context.

I totally agree that the override classes could be used here. But it means they would always have to be used if people legitimately used headings around their form groups.

In my example, the govuk-heading-ls are not part of the form-groups. They are separate headings that separate the page into sections. I am not saying I would design a form this way but there is a legitimate reason why people would do this.

I wonder if padding-top: 20px should be added by default to a heading that follows a form-group in a similar way to headings that follow paragraphs. What do you think?

chaslinn commented 5 years ago

Hi @dashouse thanks for taking the time for your detailed explanation. Unfortunately I feel I am not quite technical enough to easily understand it and am not totally clear what you are saying (sorry about that):

Are you saying the by design there will be more space below an H1 that above?

Also that for H2 and H3 that there should be less space below than above if coded correctly?

In my prototype page I also have an issue with the default headings which means that I do not get the spacing you are talking about:

image 2

It is possible that my code has errors (although I have had it checked), but I am wondering if I am missing guidance on how to ensure that my example doesn't happen. Label's and legends do complicate the matter further but just sticking to the H(s) at this point.

dashouse commented 5 years ago

Thanks @stevenaproctor, we can discuss this as a team and get back to you

dashouse commented 5 years ago

Hi @chaslinn, from looking at the screenshot the items are in a slightly different order than expected. It might be worth having a quick read of https://design-system.service.gov.uk/get-started/labels-legends-headings/ and https://design-system.service.gov.uk/patterns/question-pages/ to see how we recommend structuring question pages.

If you follow the structure of the label > hint > input, legend > hint > input and style your headings using the label and legend specific classes the relationship between each element should be much better. I can probably put together a quick example.

dashouse commented 5 years ago

Purely from a structural perspective, following the styling for labels, hints and inputs as a group the spacing will look like this.

screen shot 2018-11-20 at 17 07 53

The label and legend sizes can be changed based on preference / amount of questions

chaslinn commented 5 years ago

@dashouse thanks very much both for the example and suggestions for best practice - I will go away and read up more. That probably deals with the H2 issue to be honest (although I will check how it works with textual content below.

Any thoughts on the H1 issue?

dashouse commented 5 years ago

@chaslinn Thanks, let me look into this for you. I have tested a couple of options for the h1 and I think potentially increasing the padding-top of the govuk-main-wrapper container by 10px, therefore making the space on the top and bottom equal will be more inline with GOV.UK. I will put together a pull request and make sure I reference this issue.

chaslinn commented 5 years ago

@dashouse thanks for this, my personal preference would be to reduce the bottom margin by 10 pix or even 20 px - I think the size 6 override looks best and seems to be in line with the existing services but this is why I am asking about art direction - did we start with a graphical prototype as well as a technical concept?

dashouse commented 5 years ago

@chaslinn The implementation in GOV.UK Frontend is based on the art direction of GOV.UK. We essentially systemised the previous typographic hierarchy from GOV.UK Elements and made it as close as possible to GOV.UK itself while making them work for multiple scenarios. I'm a graphic designer first, so this isn't a technical only approach.

The issue with commenting on existing services is that because of the way the styles had been applied in GOV.UK Elements, custom spacing using Frontend Toolkit as well as changes over time there is a great deal of discrepancy in services. When doing this work we looked at many many examples of services from across multiple departments and highlighted the differences, mistakes and intentional choices before designing the solution we came up with. Now we have systemised this approach we should start seeing a lot more consistent spacing across departments and services.

The other factor here is that some people prefer to use govuk-heading-l for their h1, this has a bottom margin of 30px which may be what you're used to seeing.

The pull request I opened this morning https://github.com/alphagov/govuk-frontend/pull/1073 will increase the space above the h1 by increasing the size of the main content container, this makes it inline with GOV.UK (give or take a few px) which should help.

chaslinn commented 5 years ago

@dashouse You are right 43-45 px lower seems more common, sorry. see https://www.gov.uk/register-offices as an example (also of poor H2 spacing which I guess might be fixed by new styles now?). But it looks like we have chosen to make it larger bottom margin spacing, is that right? as in an increase to 50 px?

dashouse commented 5 years ago

It's hard to explain the level of inconsistency in all of the different apps and layouts. It was increased from a GOV.UK perspective from 45px to 50px, however it's decreased from GOV.UK Elements which was 60px.

This was really so we could hang everything off of the responsive spacing scale and have a consistent approach going forward.

GOV.UK are actually starting to pick up GOV.UK Frontend in a few of their templates so over time this problem will iron itself out eventually.

edwardhorsford commented 5 years ago

Hi 👋

I came here to ask for advice about the margin-bottom on the h1 - looks like it's come up before.

Here's an example from our service: screenshot 2019-02-06 at 12 52 19

To me, there's a lot of space between the heading and the body content. I'll probably end up reducing our h1s by one level, which will reduce the margin by default too.

Trying with govuk-heading-l - the margin is reduced, but in proportion the space still feels rather large: screenshot 2019-02-06 at 14 10 49

For reference, here's Notify's page, which uses ems, but looks to be about 11px: screenshot 2019-02-06 at 14 09 07

pflannery commented 5 years ago

Hi.

Would be nice to see the "(opens in new window)" link variations under the links section.

I've seen a smaller fonts used for "(opens in a new window)" but ultimately would prefer the guidance to come from the design system .

edwardhorsford commented 5 years ago

Would it be possible to document how to get tabular numbers? I know they exist but can't find them in the typography section, the getting started section, or in site search.

I've seen several people on the Cross Gov slack lament the lack of tabular numbers / ask that they be introduced - since we have them it feels like we're not making it obvious enough.

Knowing they're possible in the table component, I searched the source and found that the table uses @include govuk-font($size: false, $tabular: true); - could this be exposed as a class and noted in the guidance somewhere?

dashouse commented 5 years ago

Thanks @edwardhorsford, for context we have a larger goal to add some of the SCSS documentation into the site. This would include exposing more mixins and settings for styling custom elements.

I have started this work but because it's not a current priority for the team I'll post the section about this specific thing below for any future readers of this issue.


Applying font styles directly to your elements in SCSS

If you want to apply the responsive font styles directly to an element in SCSS you can use the govuk-font() mixin.

For example if you wanted your element to have 19px font size on large screens and 16px size on small screens you could set this by adding @include govuk-font(19);.

The govuk-font() mixin takes multiple arguments for font weight, tabular numbers and line-height. For example govuk-font($size: 19, $weight: regular, $tabular: false, $line-height: 1).

nacnudus commented 5 years ago

I've read the explanations here about spacing above and below headings, and as far as I can tell it should be correct for simple pages.

This means h2, h3, h4, paragraphs, although only having margin-bottom when used on their own will actually have padding-top added in certain scenarios automatically.

Providing that there is nothing stopping the adjacent sibling selectors from working such as wrapping text inside <div>'s.

But when I add <p> elements to the example, the spacing above headings is wider than below headings.

image

36degrees commented 5 years ago

@nacnudus as far as I can tell from your screenshot, you're not adding the govuk-body class to the paragraphs, which means the browser's default margins are being applied.

If you use the classes provided then the spacing rules should work as intended (and you'll also get the correct font and text colour).

Screen Shot 2019-04-15 at 16 26 26

Hope that helps.

nacnudus commented 5 years ago

@36degrees thanks, that was it. I was adding govuk-body in real life, but that was itself wrapped up something else so wasn't detected.

glenpike commented 5 years ago

Thanks for all your good work on the Design System, it's been really useful. We've been using it on our website and recent testing with a screen-reader (VoiceOver in Safari) has shown up a possible issue with the basic govuk-list class. Basically, if we use this style, the reader doesn't announce the list like it would do for the bulletted list.
This article sums it up quite well and gives a possible solution: https://www.scottohara.me/blog/2019/01/12/lists-and-safari.html

Is this something you would consider tweaking? Current workaround is to add role="list" to the <ul>

36degrees commented 5 years ago

Hi Glen,

Thanks, that's really interesting – I wasn't aware that was a thing. It sounds like something we should investigate further – would you mind raising an issue against GOV.UK Frontend?

https://github.com/alphagov/govuk-frontend/issues/new

Alternatively, I can do this for you, if you'd prefer.

glenpike commented 5 years ago

Alternatively, I can do this for you, if you'd prefer.

I have raised an issue Hope that's okay - there doesn't seem to be a template :)

36degrees commented 5 years ago

That's ace, thank you!

timpaul commented 4 years ago

The secondary text colour meets WCAG 2.1 AA colour contrast, but it's been remarked that some users might still find it hard to read. If teams have evidence either way please post it here.

edwardhorsford commented 4 years ago

I often feel like there's too much space between lead-in lines and sets of unordered bullets. Since they're meant to be read together and as a sentence, separating them by the amount paragraphs get separated doesn't feel right - and makes them harder to read and relate to the lead-in.

Example: Screenshot 2019-08-07 at 13 01 22

On GOV.UK the margin is less: Screenshot 2019-08-07 at 13 01 54

Possibly I've been marking them up wrong - I raised #1103 to add docs on how to lead in.

fofr commented 4 years ago

@timpaul We've observed a user struggling to read the grey contextual help text on forms. In the example below they could read the black text, but had difficulties with the grey text at the same font size.

They were using their own device at home. They preferred to use a handheld magnifying glass over digital zoom – which they only used occasionally. They did not try to increase the font size in their browser. The user attempted to read the grey text by using the magnifying glass and reading as close to the screen as they could.

The user indicated they have regular problems with grey text on websites.

Screen Shot 2019-08-23 at 09 43 43

This was on DfE's Apply for postgraduate teacher training prototype.

I expect us to redesign our form guidance and minimise what we put in grey text.

joelanman commented 4 years ago

We could consider using more bold, say in labels, so you could then use normal weight for hints and avoid grey.

torydunn-hmrc commented 4 years ago

It would be good to test, to make sure that doesn't become distracting in its own right. But I agree it would be best to get away from grey text.

On Fri, 23 Aug 2019 at 15:17, Joe Lanman notifications@github.com wrote:

We could consider using more bold, say in labels, so you could then use normal weight for hints and avoid grey.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alphagov/govuk-design-system-backlog/issues/64?email_source=notifications&email_token=AIUV3QUXWZRGB6EUEZJAKI3QF7WOTA5CNFSM4ELSCTGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AK3ZA#issuecomment-524332516, or mute the thread https://github.com/notifications/unsubscribe-auth/AIUV3QRYHZ5T4OQJGZF25OTQF7WOTANCNFSM4ELSCTGA .

-- Tory Dunn Head of Design | HMRC CDIO | 07392 289160

terrysimpson99 commented 4 years ago

Can I add a point about hint text which I believe goes beyond eyesight? Some users fail to notice hint text until it's pointed out to them and I think there's something about perception and processing for all users. This can be quite dramatic e.g. a user saying "Does this question mean 'x'?" and the hint text says "This means 'x'".

edwardhorsford commented 4 years ago

I'd like to make two suggestions for the typography section / govuk-frontend:

  1. Mention tabular numbers / fixed width numbers and how to use them.
  2. Make a class to give text the tabular font.

I know there's a govuk-table__cell--numeric - but it doesn't feel appropriate to use this outside of tables. Similarly teams could create their own classes with @include govuk-font($size,$tabular: true) - but it feels like something it would be good the Design System included by default.

TheresaEllul commented 4 years ago

I was reviewing the font sizes on our new service as we are following the GOV.UK Design System typography guide https://design-system.service.gov.uk/styles/typography/#headings which shows H1 is 48px, H2 is 36px and H3 is 24px, however on the GOV.UK live site the headings are H1 is 48px, but H2 is 27px which looks much better than 36px for example https://www.gov.uk/benefits-calculators. Why does the GOV.UK design system typography show different size fonts to the live GOV.UK site?

danhowarthgov commented 4 years ago

Great to see the new guidance on opening links in a new tab: https://design-system.service.gov.uk/styles/typography/#opening-links-in-a-new-tab

Just one thing. What's the reason to drop the indefinite article, and make it "(opens in new tab)" instead of "(opens in a new tab)"? Is there evidence that parenthetical content like this doesn't need to be a full sentence?

m-green commented 4 years ago

Hi @danhowarthdwp - you're right that we'd usually add 'a' (as we have in the page title for example). But the idea here was to be consistent with the wording that users will be familiar with from browsers. For example, Chrome's right-click menu uses "Open Link in New Tab" and "Open Link in New Window". Hope that makes sense!

jeanesims commented 3 years ago

We've had some feedback on the Capital Gains Tax on UK property service on how to code captions and H1s when they are used together so they are more accessible for screenreader users. The details are below.

image

frankieroberto commented 3 years ago

@jeanesims in this instance, I'd suggest keeping the <h1> within the fieldset legend, as that's the main title of the page, but moving the span with the "Create a Capital Gains Tax on UK property account" text out of the fieldset, and out of the form completely.

See Heading with caption which describes how the caption can either be within or outside of the <h1>, depending on whether the caption "should be considered part of the page heading". Possibly the guidance could be clearer here?!

In your case though, I'd be tempted to try dropping the text altogether, given that it’s quite long, and perhaps users already know which flow they are within?

Adam-Hindle commented 2 years ago

Hi All,

I have a question about links that has come up during an audit.

If a link is an entire sentence and has no other text around it, does it require a full stop at the end of it?

Screen Shot 2021-10-04 at 17 50 18

My understanding was that if the entire sentence was a link, it didn't require a full stop but the auditor disagrees.

Does anyone know of the correct approach here? Also if there is any documentation supporting either version, as I can't find any on the design system or elsewhere. Thanks!

edwardhorsford commented 2 years ago

I might consider this a grey area where you use your best judgement about what makes sense from a content point of view - if it's a complete sentence and it makes sense to have a full stop, then have one.

With that said, in the context of the screenshot you’ve added I wouldn't normally add one for microcopy / action links like this.

See below for Screenshot 2021-10-04 at 18 33 30 some similar action links from our service:

I know some teams have added punctuation to fix issues with AT not reading these discreetly from other ui on the page. I think there are other technical approaches that can be taken to make sure these are read out independently though - so you shouldn't need to add punctuation purely to get AT to behave.

terrysimpson99 commented 2 years ago

It's not just full stops, it's punctuation at the end of a phrase.

  1. You can debate it in terms of accessibility: Without punctuation, some screenreaders in some circumstances act as if two phrases are connected.
  1. You can debate it in terms of non-accessibility reasons such as aesthetics, or style If you're debating non-accessibility reasons, I'd call it a matter of personal preference.
Tosin-Balogun commented 2 years ago

Hi GOVUK community, does anyone have any research to share about lead paragraph text?

This one below

Screenshot 2022-04-29 at 10 57 58

We at the NHS are trying to evaluate it's use case to find out if there's evidence to show how effective it has been. Please, if you do have any insight, evidence (big or small), we would really appreciate it

You can reach out to me or share whatever you know on our Github backlog https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/106