alphagov / govuk-design-system

One place for service teams to find styles, components and patterns for designing government services.
https://www.gov.uk/design-system
MIT License
495 stars 229 forks source link

Add examples of radio and checkbox legends that are not page headings #1364

Closed fofr closed 3 years ago

fofr commented 3 years ago

Every example shown has isPageHeading set to true: https://design-system.service.gov.uk/components/radios/ https://design-system.service.gov.uk/components/checkboxes/

It's not clear from the examples:

joelanman commented 3 years ago

Mentioned here, I think we only tackled part of it:

https://github.com/alphagov/govuk-design-system/issues/1021

fofr commented 3 years ago

This had a knock-on effect which meant a formbuilder gem a few services are using has defaulted to using H1s in places that aren't appropriate.

kellylee-gds commented 3 years ago

Discussed with the team at triage today.

What

Add examples of legends that are not page headings to our form components.

Why

Without these examples some users assume that the only way to add legends is as headings.

Who needs to know about this

Content designer, developers

Done when

Example and additional guidance added to:

Then: