alphagov / govuk-design-system

One place for service teams to find styles, components and patterns for designing government services.
https://www.gov.uk/design-system
MIT License
512 stars 232 forks source link

Publish general accessibility acceptance criteria that all components should meet, and explain how to write component specific accessibility acceptance criteria #1781

Closed kellylee-gds closed 3 years ago

kellylee-gds commented 3 years ago

What

Draft and publish accessibility acceptance criteria to be used when contributing new components to GOV.UK Design System.

Why

Whilst building the Notification banner and Cookie banner components we used a template to check how components in the Design System should behave with various assistive technologies. We feel there is value publishing this information so it can be used by future contributors.

Who needs to know about this

Hanna, Eoin

Done when

EoinShaughnessy commented 3 years ago

This may change in future, but for now the likeliest location for this content is probably within https://github.com/alphagov/govuk-frontend/tree/main/docs/contributing.

EoinShaughnessy commented 3 years ago

Unless we wanted to add it here: https://design-system.service.gov.uk/community/?

hannalaakso commented 3 years ago

Early draft here: https://docs.google.com/document/d/133tfhMrCzpZizAOtggzgXGJJRCJKt7KR6M3WUWZekk0/edit

EoinShaughnessy commented 3 years ago

We've shared the doc with the rest of the Design System team for internal review.

hannalaakso commented 3 years ago

@vanitabarrett has kindly offered to do a frontend dev review of the draft.

EoinShaughnessy commented 3 years ago

We've updated the doc following feedback from the Frontend and accessibility communities. I've now sent the doc for pre-i.

EoinShaughnessy commented 3 years ago

Doc has passed pre-i so I've sent it for 2i.

EoinShaughnessy commented 3 years ago

Doc has passed 2i. Will now publish it.