alphagov / govuk-design-system

One place for service teams to find styles, components and patterns for designing government services.
https://www.gov.uk/design-system
MIT License
512 stars 232 forks source link

Make sure that new Nunjucks options have been reviewed and match latest version #2379

Closed 36degrees closed 2 years ago

36degrees commented 2 years ago

What

Make sure that any new Nunjucks options introduced as part of v4.4.0 have been reviewed by a tech writer.

Once they've been reviewed, ensure that any changes have been made in the YAML files before we do the release.

Why

Because the Nunjucks macro options table in the Design System is generated automatically based on the macro-options.json file in the package (which is generated from the component YAML files) we need to make sure we're happy with this part of the technical documentation before we do the release, as we won't be able to change it until the next release.

Who needs to work on this

Developer, tech writer

Who needs to review this

Developer, tech writer

Done when

romaricpascal commented 2 years ago

Worth noting that the character count component has no entry in its YAML file at the moment, awaiting a decision on #2378.

claireashworth commented 2 years ago

Options have been reviewed as part of a larger doc for internationalisation and configuring components. It has gone to another tech writer for 2i.

36degrees commented 2 years ago

I believe this has been done as part of https://github.com/alphagov/govuk-frontend/pull/2985