alphagov / govuk-design-system

One place for service teams to find styles, components and patterns for designing government services.
https://www.gov.uk/design-system
MIT License
512 stars 232 forks source link

Update sub-table link text in nunjucks macros #4309

Closed owenatgov closed 3 days ago

owenatgov commented 3 days ago

What

Updates the link text for the generated links in our examples partial, where a nunjucks macro option has it's own params and the link jumps to that option's own option table.

Why

Part of https://github.com/alphagov/govuk-design-system/issues/4267. This change will resolve 64 identified links that need clearer link text.

Notes

The first variation on line 120, which is used when a sub option is referencing a component that isn't the hint or label "components", doesn't have any instances across our library. This makes it hard to test. I was able to hard code it appearing by removing the label and hint condition. See the below screen shot of an example from the Text input options:

Screenshot of hint and label text input options with different link text
netlify[bot] commented 3 days ago

You can preview this change here:

Name Link
Latest commit b29aa471fdd5a8c1bcb0c1218d8ce35da5ab770a
Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/673b5907e404c90008d52388
Deploy Preview https://deploy-preview-4309--govuk-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.