alphagov / govuk-design-system

One place for service teams to find styles, components and patterns for designing government services.
https://www.gov.uk/design-system
MIT License
511 stars 232 forks source link

Details component guidance should give other components as options #753

Closed NickColley closed 5 years ago

NickColley commented 5 years ago

Details component guidance should give other components as options

This issue is reserved for people who are attending the Learn GitHub for content designers workshop.

Description

In the 'When not to use this component' section of the details component guidance, there should be guidance to give other components such as tabs and accordions as examples of what might be more appropriate.

Screenshot of issue

Screenshot of issue in the design system

Step by step

1. Claim this issue

Comment below to let other people know that you're working on this issue.

2. Edit the markdown file

You may be asked if you want to fork this repository. You'll need select 'fork this repository and propose changes'.

image

You can find the markdown file for this change by going to:

https://github.com/alphagov/govuk-design-system/edit/master/src/components/details/index.md.njk#L23

In the markdown file make the following changes:

Do not use the details component to hide information that the majority of your users will need.

+ ## Details, accordions and tabs

+ Details, [accordions](/components/accordion/), and [details](/components/tabs/) all hide sections of content which a user can choose to reveal.

+ Use the details component instead of tabs or an accordion if you only have 1 section of content.

+ The details component is less visually prominent than tabs and accordions, so tends to work better for content which is not as important to users.

## How it works

3. Propose a change

Once you’re happy, scroll to the bottom of the page to ‘propose file change’.

Add a brief description of what you have changed in the first field. This information will be added to the file’s changelog. Try to be as clear as possible, so that future users can understand what you have done.

If you need to provide information about why you made the change, you can add more detail in the larger field below.

When you are happy with your description, select ‘propose file change’. You will have a chance to review and confirm your changes on the next page.

Screenshot of propose file change section

4. Confirm your changes

You will be shown a confirmation page where you can review the changes you’ve made. If you spot a mistake, you can go back to the previous page and correct it. If you are happy, select ‘Create pull request’. You will have one more chance to review your change on the next page before you submit it to the GOV.UK Design System team to review. Screenshot of comparison screen

5. Create a pull request

A pull request is a request sent to the team who maintains the project you’re making changes to – in this case, the GOV.UK Design System team.

It tells them what you’ve changed and gives them the option to ‘pull’ your changes into the project where it can then be published.

At this point, you can write additional comments about the work you’ve done if you want to.

These will be shared with the GOV.UK Design System team when you submit your proposed change.

It will be pre-filled with the information you entered when you proposed the file change in step 3. Please be aware that updating the information here will not change the original description you provided, but will send it in addition.

Screenshot of final confirmation screen

Once you’re happy, select ‘Create pull request’.

6. Done, wait for a review from the team

The GOV.UK Design System team will be notified of your proposal and will review it as soon as possible.

Questions

If you’ve got a question, you can comment in this issue or email the Design System team on govuk-design-system-support@digital.cabinet-office.gov.uk

StuLorente-Cronin commented 5 years ago

I'll pick this up.