search

alphagov / govuk-docker

GOV.UK development environment using Docker 🐳
MIT License
82 stars 22 forks source link

Pin Dockerfiles to buildpacks-dep:bullseye #666

Closed chrisroos closed 1 year ago

chrisroos commented 1 year ago

I ran into a problem this morning when running make publishing-api. It was failing with the following error:

LoadError: libssl.so.1.1: cannot open shared object file: No such file or directory - /root/.rbenv/versions/3.1.2/lib/ruby/3.1.0/x86_64-linux/openssl.so
/govuk/publishing-api/config/application.rb:3:in `<main>'
/govuk/publishing-api/Rakefile:4:in `<main>'
(See full trace by running task with --trace)
make: ***
[/home/chrisroos/govuk/govuk-docker/projects/publishing-api/Makefile:2:publishing-api] Error 1

By not specifying a tag of the buildpack-deps image we were implicitly using latest which, as far as I can tell, is the same as stable. The stable tag was recently updated from Debian 11 (Bullseye) to 12 (Bookwork). The upgrade from Debian 11 to 12 brings an upgrade of OpenSSL from 1.1.1n to 3.0.9 and this appears to be the cause of the problems I was seeing.

By specifying the bullseye tag I believe we should be retaining the behaviour from before the change to the stable tag.

Prior to this change running make publishing-api, make asset-manager and make whitehall all failed with similar SSL problems. After this change they all build successfully.

kevindew commented 1 year ago

The change looks good, but I think we should add a comment about it as a todo to fix.

As I understand from my digging this is an issue caused by using Ruby < 3.1.4, so it'd be good to state that we can change this line back to the stable branch of buildpack-deps once all apps are using that.

chrisroos commented 1 year ago

Thanks @kevindew :+1: I've added some comments. Is that the sort of thing you had in mind?