search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.16k stars 320 forks source link

html validation errors #1298

Closed joelanman closed 5 years ago

joelanman commented 5 years ago

In HMTL5 validator we get the following errors:

Error: Attribute src not allowed on element image at this point.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Error: Element image is missing required attribute height.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Error: Element image is missing required attribute width.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag
36degrees commented 5 years ago

We can fix the latter two, but the first one is intentional as we're using it as a fallback for the SVG.

joelanman commented 5 years ago

probably related to #1280