Closed dabd closed 4 years ago
Can I work in this issue?
Heya @StheffanyHadlich!
Thanks for offering to help out, we think this issue is more than just documentation so the GOV.UK Design System team will pick this up.
We have some first timer issues over on the GOV.UK Design System website repository if you're interested in contributing there: https://github.com/alphagov/govuk-design-system/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22
Oh, thank you
Review from @m-green
In the
date-input
componentid
is documented as optional but treated as a required parameter when creating thehintId
anderrorId
(if it is not provided it will generate an id starting with hyphen, which is probably not the intended result). It is treated as optional elsewhere.Should it be considered as a required parameter instead?
In the
radios
component whenidPrefix
is not supplied it falls back to usingname
. Does it make sense to use the same approach here?Same problem here: https://github.com/alphagov/govuk-frontend/blob/master/src/govuk/components/tabs/template.njk#L3